ComboboxControl: Replace undefined variable usage with color-mix for disabled selection
#69621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
fe899f3 to
2e494b3
Compare
ciampo
approved these changes
Mar 19, 2025
|
Thanks for the review, @ciampo.
Will follow-up on this shortly! |
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…for disabled selection (WordPress#69621) * fix: remove transparent variant for accent color in theme variables * fix: use `color-mix` to derive color accent variant * fix: use `background` and reduce alpha to `4%` * chore: add changelog --- Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and Why?
Closes #69593
This PR:
--wp-components-color-accent--rgbproperty as thergbvariant does not exist.$components-color-accent-transparent-40SASS variable in favor ofcolor-mix().dark backgrounds.How?
The corresponding
scssfile is updated to reflect the above changes.Testing Instructions
npm run storybook:dev)Testing Instructions for Keyboard
Same.
Screenshots
P.S. Please note that a tinted background (although faint) has been added to the first (disabled) option. The second option may appear invisible due to the lack of theming support, which will be addressed once theming is implemented for the component. (Ref. #69593 (comment))