Skip to content

ComboboxControl: disabled options don't show with dark themes #69593

Closed
@ciampo

Description

@ciampo

Image

From #61294 (comment) :

While reviewing --wp-components-color-* variables, @mirka and I came across this change that was added just before merging the PR and escaped our review.

  • the --wp-components-color-accent--rgb custom property does not exist (we don't have any --rgb variants);
  • the $components-color-accent-transparent-40 SASS variable doesn't need to exist as a common variable, as it can be derived directly where it's needed via the color-mix() function
  • it doesn't work on dark backgrounds (ie dark mode)

We should remove this variable and figure out an alternative solution that only makes use of existing variables and works with all possible theme combinations.

Metadata

Metadata

Assignees

No one assigned

    Labels

    [Package] Components/packages/components[Status] In ProgressTracking issues with work in progress[Type] BugAn existing feature does not function as intended

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions