Skip to content

Image: fixed resetAll to return image resolution to default value #70398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2025

Conversation

shimotmk
Copy link
Contributor

What?

Related #70122

Why?

Clicking Reset all doesn't reset the resolution to default.
Fixed it to go back to full resolution like in #70122.

How?

Testing Instructions

  1. Open a post or page.
  2. Insert an image and select a media file.
  3. Change its resolution.
  4. Confirm that it doesn't reset to the first available option.

Testing Instructions for Keyboard

Screenshots or screencast

Before

before.mp4

After

after.mp4

@shimotmk shimotmk requested a review from artemiomorales as a code owner June 12, 2025 09:59
Copy link

github-actions bot commented Jun 12, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Block] Image Affects the Image Block labels Jun 12, 2025
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, @shimotmk!

@Mamaduka Mamaduka added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jun 12, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jun 12, 2025
@shimotmk
Copy link
Contributor Author

Thank you @Mamaduka
Can you merge it please?

@Mamaduka Mamaduka merged commit 45bac28 into WordPress:trunk Jun 24, 2025
59 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.1 milestone Jun 24, 2025
@shimotmk shimotmk deleted the fix/resetall-mesia-size branch June 24, 2025 09:15
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
…rdPress#70398)

Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants