Social Links: Allow icon size to be reset and honor theme.json styles #70380
+6
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #70318
This PR updates the SocialLinksEdit component to:
undefined
in the size attribute instead of hardcodinghas-normal-icon-size
has-normal-icon-size
class.Why?
Currently, when the icon size is set and reset, the
has-normal-icon-size
class remains in the markup. This overrides custom styles set via theme.json or additional CSS due to higher specificity.By introducing an explicit "Default" option that doesn't apply a class, this change ensures the block respects styles defined in theme.json. It also improves clarity in the UI, indicating when the default size is being used.
How?
Testing Instructions
Testing Instructions for Keyboard
Same
Screenshots or screencast
When the following style is added to theme.json
After Icon size is reset