Skip to content

Warning: Replace popoverProps.position to popoverProps.placement #70347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

SainathPoojary
Copy link
Contributor

@SainathPoojary SainathPoojary commented Jun 6, 2025

What?

Related to: #44401

Replaces the deprecated position prop with the recommended placement prop in the Warning component’s Popover

Why?

The position prop in Popover is deprecated. This update ensures the component uses the latest API.

Testing Instructions

  1. Run npm run storybook:dev.
  2. Navigate to block-editor/components/warning story.
  3. Interact with the “More options” (three dots) menu in the Warning.
  4. Ensure the dropdown appears in the correct position relative to the button.

Screenshots or screencast

Before:

after.mov

After:

before.mov

@SainathPoojary SainathPoojary requested a review from ellatrix as a code owner June 6, 2025 09:01
Copy link

github-actions bot commented Jun 6, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: SainathPoojary <sainathpoojary@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Type] Code Quality Issues or PRs that relate to code quality [Package] Block editor /packages/block-editor labels Jun 9, 2025
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @SainathPoojary!

@Mamaduka Mamaduka added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jun 10, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jun 10, 2025
@Mamaduka Mamaduka merged commit 366670e into WordPress:trunk Jun 10, 2025
70 of 71 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.1 milestone Jun 10, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
…dPress#70347)

Co-authored-by: SainathPoojary <sainathpoojary@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Block editor /packages/block-editor [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants