-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Post Navigation Link: Refactor settings panel to use ToolsPanel #70276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Navigation Link: Refactor settings panel to use ToolsPanel #70276
Conversation
Not sure if this relates to the failed check, but I was doing similar block updates recently and @t-hamano pointed out that the block I was working on did not have an |
@t-hamano I've seen you mention this issue on a couple other PRs relating to refactoring to use the |
No. See #67813 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code itself looks good.
I've seen you mention this issue on a couple other PRs relating to refactoring to use the
ToolsPanel
, is there a known fix for the order inconsistency in the block resets?
Let's hear from others whether this is acceptable or not. See #67952 (comment)
Hey @t-hamano, Screen.Recording.2025-06-02.at.5.32.34.PM.mov |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Personally, I prefer not to change the order as I don't think this is a fundamental solution. |
Agreed @t-hamano, Changing the order feels like a workaround rather than a fundamental solution. |
For now, it seems better to accept this issue and prioritize the migration to ToolsPanel. See #67952 (comment). Let's merge this. |
…Press#70276) Co-authored-by: SainathPoojary <sainathpoojary@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: troychaplin <areziaal@git.wordpress.org>
Closes: #70273
What?
Refactored the Post Navigation Link Block to use ToolsPanel instead of PanelBody.
Screenshots or screencast
Screen.Recording.2025-06-02.at.5.36.39.PM.mov