Skip to content

Comment Edit Link: Refactor settings panel to use ToolsPanel #70247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SainathPoojary
Copy link
Contributor

@SainathPoojary SainathPoojary commented May 28, 2025

Closes #70239

What?

Refactored the Comment Edit Link Block to use ToolsPanel instead of PanelBody.

Screenshots or screencast

Before:
image

After:

2025-05-30.20-07-45.mp4

@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. [Block] Comment Edit Link Affects the Comment Edit Link Block labels May 29, 2025
@SainathPoojary SainathPoojary marked this pull request as ready for review May 30, 2025 15:39
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: SainathPoojary <sainathpoojary@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@t-hamano
Copy link
Contributor

t-hamano commented Jun 1, 2025

@SainathPoojary can you refresh this PR? I don't know why, but PHP unit tests are failing repeatedly.

@SainathPoojary SainathPoojary force-pushed the refactor-comment-edit-link-setting branch from 494c37b to 16125b8 Compare June 2, 2025 10:35
@t-hamano t-hamano merged commit 1553653 into WordPress:trunk Jun 2, 2025
59 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.0 milestone Jun 2, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
…ss#70247)

* Comment Edit Link: Refactor settings panel to use ToolsPanel

* Comment Edit Link: Change import order in edit.js

Co-authored-by: SainathPoojary <sainathpoojary@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Comment Edit Link Affects the Comment Edit Link Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor "Settings" panel of Comment Edit Link block to use ToolsPanel instead of PanelBody
2 participants