Skip to content

Editor: Add label inTextareaControl in CollabSidebar #70133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 16, 2025
Merged

Editor: Add label inTextareaControl in CollabSidebar #70133

merged 4 commits into from
May 16, 2025

Conversation

im3dabasia
Copy link
Contributor

@im3dabasia im3dabasia commented May 15, 2025 •
edited
Loading

What?

Part of: #51740

I conducted an extensive search throughout the codebase to identify controls that are unlabeled and found 1 such instance:

  1. TextareaControl in CommentForm

Why?

All form controls must be labeled.

How?

  • Added label prop to TextareaControl in CommentForm.

Testing Instructions

  1. Enable experimental inline commenting option under Gutenberg -> Experiments
  2. Edit any post/page
  3. Add any block, Click on more menu in block toolbar, Look for comment option.
  4. It would open the thread in sidebar, Where you can add comment.
  5. Observe that the aria-label is now there in the input container

Screenshot

Before After
Screenshot 2025-05-15 at 5 56 18 PM Screenshot 2025-05-15 at 5 57 26 PM

@im3dabasia im3dabasia requested a review from ajitbohra as a code owner May 15, 2025 13:06
@github-actions GitHub Actions
Copy link

github-actions bot commented May 15, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

t-hamano
t-hamano reviewed May 16, 2025
View reviewed changes
@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Collaborative Workflows Phase 3 of the Gutenberg roadmap around all-things related to collaborative workflows labels May 16, 2025
t-hamano
t-hamano reviewed May 16, 2025
View reviewed changes
@im3dabasia im3dabasia force-pushed the fix/labels-in-control branch from cdd9a22 to d4af295 Compare May 16, 2025 10:50
t-hamano
t-hamano approved these changes May 16, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@t-hamano
Copy link
Contributor

@im3dabasia Can you update the PR title and description with the actual code changes? I think this PR purely makes changes to the collaboration sidebar only.

@im3dabasia im3dabasia changed the title Components: Add labels to interactive controls Editor: Add label in TextareaControl in CollabSidebar May 16, 2025
@im3dabasia im3dabasia changed the title Editor: Add label in TextareaControl in CollabSidebar Editor: Add label inTextareaControl in CollabSidebar May 16, 2025
@im3dabasia
Copy link
Contributor Author

@im3dabasia Can you update the PR title and description with the actual code changes? I think this PR purely makes changes to the collaboration sidebar only.

@t-hamano , Fixed it. 💯

@im3dabasia im3dabasia requested a review from t-hamano May 16, 2025 11:44
@t-hamano t-hamano merged commit 92b671d into WordPress:trunk May 16, 2025
62 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.9 milestone May 16, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
@im3dabasia @t-hamano @chriszarate
Editor: Add label inTextareaControl in CollabSidebar (WordPress#70133)
11f4b45 
* feat: Add labels in menu and comment-form

* feat: Add labels in menu and comment-form

* fix: Add official label prop and hideLabelFromVision

* revert: Label in search-control

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@t-hamano t-hamano Awaiting requested review from t-hamano

Assignees
No one assigned
Labels
Collaborative Workflows Phase 3 of the Gutenberg roadmap around all-things related to collaborative workflows [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 20.9
Development

Successfully merging this pull request may close these issues.
2 participants
@im3dabasia @t-hamano