Skip to content

Add example doc comment #70116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025
Merged

Conversation

Infinite-Null
Copy link
Contributor

What?

Related to: #42125
PR: #69984

This PR adds the example doc comment for following:

Selector:

  • isWidgetSavingLocked

Action:

  • lockWidgetSaving
  • unlockWidgetSaving

Which was introduced in PR: #69984

Copy link

github-actions bot commented May 14, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Infinite-Null <ankitkumarshah@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added the [Type] Developer Documentation Documentation for developers label May 16, 2025
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It would be better if you applied strict code formatting with JSDoc.

@Infinite-Null Infinite-Null requested a review from t-hamano May 22, 2025 06:35
@Infinite-Null
Copy link
Contributor Author

Hi @t-hamano,
I have made the necessary changes. Please review it at your convenience.

@t-hamano t-hamano merged commit 5cde2a6 into WordPress:trunk May 22, 2025
60 checks passed
@t-hamano t-hamano added the [Package] Edit Widgets /packages/edit-widgets label May 22, 2025
@github-actions github-actions bot added this to the Gutenberg 20.9 milestone May 22, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
* Add example doc comment

* Adjust indentation and formatting

Co-authored-by: Infinite-Null <ankitkumarshah@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Edit Widgets /packages/edit-widgets [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants