Skip to content

Enable Code block content editing in contentOnly #70111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Sukhendu2002
Copy link
Contributor

What?

This PR enhances the Code block to support editing of code content when the block is in contentOnly mode.
This enhancement was identified while working on #70100

Testing Instructions

  1. Create a Group block
  2. Set the Group block's templateLock attribute to "contentOnly"
  3. Insert a Code block inside this Group
  4. Try to edit the code content

Screenshots or screencast

Screen.Recording.2025-05-14.at.12.36.58.AM.mov

@Sukhendu2002 Sukhendu2002 marked this pull request as ready for review May 13, 2025 20:03
Copy link

github-actions bot commented May 13, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Sukhendu2002 <sukhendu2002@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Block] Code Affects the Code Block labels May 14, 2025
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Sukhendu2002!

@Mamaduka Mamaduka added the props-bot Adding this label triggers the Props Bot workflow for a PR. label May 14, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label May 14, 2025
@Mamaduka Mamaduka merged commit 93ca69a into WordPress:trunk May 14, 2025
88 of 105 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.9 milestone May 14, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
Co-authored-by: Sukhendu2002 <sukhendu2002@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Code Affects the Code Block [Feature] Write mode [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants