Skip to content

SuggestionsList: Remove unused code #70195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
Merged

Conversation

Mamaduka
Copy link
Member

What?

PR removes the leftover ref effect cleanup and cancelAnimationFrame call, which was never executed since rafId is always undefined.

Related PRs: #44573 and #59085, the latter removed rAF call.

Testing Instructions

None.

@Mamaduka Mamaduka self-assigned this May 23, 2025
@Mamaduka Mamaduka requested a review from ajitbohra as a code owner May 23, 2025 13:40
@Mamaduka Mamaduka added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components labels May 23, 2025
@Mamaduka Mamaduka merged commit b80232f into trunk May 23, 2025
65 of 67 checks passed
@Mamaduka Mamaduka deleted the remove/suggestion-list-dead-code branch May 23, 2025 17:34
@github-actions github-actions bot added this to the Gutenberg 21.0 milestone May 23, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant