ServerSideRender: Colocate delayed spinner logic #70147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
commented
May 16, 2025
|
|
||
| useEffect( () => { | ||
| if ( ! isLoading ) { | ||
| setShowLoader( false ); |
There was a problem hiding this comment.
Note: This is just a safeguard for the future. Currently, the component will unmount when isLoading settles on false.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
May 16, 2025
| @@ -221,7 +227,7 @@ export default function ServerSideRender( props ) { | |||
|
|
|||
| if ( isLoading ) { | |||
| return ( | |||
| <LoadingResponsePlaceholder { ...props } showLoader={ showLoader }> | |||
| <LoadingResponsePlaceholder { ...props } isLoading={ isLoading }> | |||
There was a problem hiding this comment.
Minor, but if we're worried about back-compat, I can revert the prop name, or just add a changelog entry about it.
There was a problem hiding this comment.
I think this component is rendered when isLoading is true, so won't the value of the isLoading prop always be true?
There was a problem hiding this comment.
That's true, mostly passing the value as a safeguard for future changes. Same as here - #70147 (comment).
|
Size Change: +17 B (0%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
t-hamano
approved these changes
May 20, 2025
There was a problem hiding this comment.
LGTM!
Minor, but if we're worried about back-compat, I can revert the prop name, or just add a changelog entry about it.
As far as I can tell, I don't believe there are any consumers that use this prop, but I think we'll need to add a CHANGELOG entry at least.
|
Thanks, @t-hamano! |
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR updates
ServerSideRenderand moves the delayed snipper logic inside the loading placeholder component.Why?
LoadingResponsePlaceholder.Testing Instructions
Testing Instructions for Keyboard
Same.