Skip to content

Guide: Make next and previous button text customizable #69907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 16, 2025

Conversation

yogeshbhutkar
Copy link
Contributor

@yogeshbhutkar yogeshbhutkar commented Apr 15, 2025

What?

Closes #69906

This PR introduces support for customizing the next and previous button text in the Guide component.

Why?

Enhances text customization options for the next and previous buttons.

How?

Two new properties nextButtonText and previousButtonText were added to the Guide component.

Testing Instructions

  1. Run storybook locally. (npm run storybook:dev)
  2. Try adding nextButtonText and previousButtonText props here.
  3. Confirm the values appear correctly as the next and previous text in the Guide component.

Testing Instructions for Keyboard

Same.

@yogeshbhutkar yogeshbhutkar changed the title Guide: Add customizable next and previous button text Guide: Make next and previous button text customizable Apr 15, 2025
@yogeshbhutkar yogeshbhutkar marked this pull request as ready for review April 15, 2025 11:33
Copy link

github-actions bot commented Apr 15, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: ivan-ottinger <ivanottinger@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Feature] UI Components Impacts or related to the UI component system labels Apr 15, 2025
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @yogeshbhutkar!

Could you rebase this branch on top of the latest trunk?

@yogeshbhutkar yogeshbhutkar force-pushed the enhance-69906/guide-component branch from 3a80f41 to 5460a67 Compare April 16, 2025 11:19
@Mamaduka Mamaduka merged commit ea80bab into WordPress:trunk Apr 16, 2025
59 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.8 milestone Apr 16, 2025
@ivan-ottinger
Copy link
Contributor

Thank you very much for this quick PR, @yogeshbhutkar and @Mamaduka!

sejas pushed a commit to Automattic/studio that referenced this pull request May 2, 2025
…1315)

* Add a patch based on WordPress/gutenberg#69907 that hasn't been release as a part of
`wordpress-components`
* This patch adds customizations for Next and Previous buttons for the Guide component
use custom translated Next and Previous buttons
* Use custom translated Next and Previous buttons
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
…#69907)

Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: ivan-ottinger <ivanottinger@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guide: Make Next and Previous buttons customizable
3 participants