Scripts: Fix blocks manifest generation when directory name has space #69766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hey @t-hamano, Screencast:Screen.Recording.2025-03-31.at.5.30.42.PM.mov |
gziolo
approved these changes
Mar 31, 2025
gziolo
added a commit
that referenced
this pull request
Apr 1, 2025
…#69766) * Scripts: Fix blocks manifest generation when directory name has space * Add changelog Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org> Co-authored-by: Infinite-Null <ankitkumarshah@git.wordpress.org> Co-authored-by: srikat <srikat@git.wordpress.org>
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…WordPress#69766) * Scripts: Fix blocks manifest generation when directory name has space * Add changelog Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org> Co-authored-by: Infinite-Null <ankitkumarshah@git.wordpress.org> Co-authored-by: srikat <srikat@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #69760
Follow-up #69578
Why?
If the scripts command has the
--blocks-manifestflag, thebuild-blocks-manifestcommand is executed internally. However, if the scripts is executed inside the directory with spaces, the following incorrect command is generated:Because there is no quote, the following invalid command will actually be executed:
Testing Instructions
Local Sites)npx @wordpress/create-block test-blocktest-blocknpm run startornpm run buildLocal Sites/test-block/build/directory doesn't haveblocks-manifest.phpfileLocal Sites/test-block/node-modules/@wordpress/scripts/config/webpack.config.jsfile and add changes that are the same as this PRnpm run startornpm run buildagainLocal Sites/test-block/build/directory hasblocks-manifest.phpfile