Navigation Link: Improve performance by only requesting entities when selected #69633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @dretzlaff. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Mar 19, 2025
| @@ -111,14 +111,14 @@ const useIsInvalidLink = ( kind, type, id ) => { | |||
| // Fetching the posts status is an "expensive" operation. Especially for sites with large navigations. | |||
| // When the block is rendered in a template or other disabled contexts we can skip this check in order | |||
| // to avoid all these additional requests that don't really add any value in that mode. | |||
| if ( blockEditingMode === 'disabled' ) { | |||
| if ( blockEditingMode === 'disabled' || ! enabled ) { | |||
There was a problem hiding this comment.
Left blockEditingMode check. This handles cases when the Navigation block can be selected, but its children have editing disabled.
|
Size Change: +93 B (+0.01%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
fabiankaegy
reviewed
Mar 19, 2025
There was a problem hiding this comment.
@Mamaduka This is a nice improvement :) I think we need to fine tune it a little bit more though 🤔
In testing this I find it odd that the "invalid" indicator disappears when I have another child of the navigation block selected...
I would kind of like to check if the navigation block is selected or if it has a selection within any of it's child blocks (deeply nested) 🤔
CleanShot.2025-03-19.at.15.39.05.mp4
49f1890 to
f852101
Compare
|
@fabiankaegy, I updated the checks, and they should be working better. Note: The validation info will disappear when the selection moves out of the navigation block. |
|
thanks for the PR!
To solve the performance problem, we need to tolerate this behavior, right? |
Yes, it's a trade-off, but minor, in my opinion. |
t-hamano
approved these changes
Mar 23, 2025
fabiankaegy
approved these changes
Mar 24, 2025
|
@Mamaduka I think this one might be worth flagging for a point release. |
Sourav61
pushed a commit
to Sourav61/gutenberg
that referenced
this pull request
Mar 24, 2025
… selected (WordPress#69633) * Navigation Link: Improve performance by only requesting entities when selected * Update selector logic for enabling link validation Unlinked contributors: dretzlaff. Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: jordesign <jordesign@git.wordpress.org>
|
I am checking the PRs with the "Backport to WP Minor Release" label applied to clarify which PRs should be backported to the WordPress 6.8.2 release. This PR does not fix the issues that first appeared in 6.8, but is just a performance improvement and may be a candidate for a minor release. However, note that there is a slight visual change:
|
|
I think similar performance fixes are okay to backport into a minor release, especially now that there won't be another major release until next year. This is similar to #69627. |
t-hamano
added a commit
that referenced
this pull request
Jun 30, 2025
… selected (#69633) * Navigation Link: Improve performance by only requesting entities when selected * Update selector logic for enabling link validation Unlinked contributors: dretzlaff. Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: jordesign <jordesign@git.wordpress.org>
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
… selected (WordPress#69633) * Navigation Link: Improve performance by only requesting entities when selected * Update selector logic for enabling link validation Unlinked contributors: dretzlaff. Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: jordesign <jordesign@git.wordpress.org>
Mamaduka
added a commit
that referenced
this pull request
Jul 8, 2025
… selected (#69633) * Navigation Link: Improve performance by only requesting entities when selected * Update selector logic for enabling link validation Unlinked contributors: dretzlaff. Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: jordesign <jordesign@git.wordpress.org>
|
This PR was cherry-picked into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #42904.
Related #69627.
PR improves Navigation Link block performance when loading editors and avoids preemptively requesting item status metadata.
This approach is similar to #17504.
Why?
See: #42904 and #69563.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast