Site Title: Prevent saving and rendering a value made of only spaces #69628
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #60467
Prevents the Site Title block from saving and rendering values made only of whitespace characters
Why?
The Site Title block was inconsistent with the classic admin behavior - it would allow saving site titles with only spaces, which created empty links on the front end. Empty links are problematic for SEO and accessibility.
This inconsistency created a situation where:
How?
The solution addresses the issue in two places:
edit.js
): Trim whitespace from the title before saving itindex.php
): Skip rendering if the site title consists only of whitespaceTesting Instructions
Screencast
Before
Screen.Recording.2025-03-20.at.16.59.34.mp4
After
Screen.Recording.2025-03-20.at.17.08.16.mov