-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Site Editor: show pattern category step in navigation for mobile #69206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The following navigation is out of the scope of this PR: We should probably navigate like this: To fix this, I think we need to modify this area of the gutenberg/packages/edit-site/src/components/site-hub/index.js Lines 159 to 171 in 1976565
|
Size Change: +34 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should do this. I don’t see any drawbacks and being able to avoid loading all patterns seems especially pertinent in the mobile view. Code LGTM and works as expected in testing.
@stokesman Thanks for the review! |
…dPress#69206) Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: stokesman <presstoke@git.wordpress.org>
…dPress#69206) Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: stokesman <presstoke@git.wordpress.org>
What?
Alternative to #67505
Navigate to the Pattern category list in mobile view. This allows access to template parts in mobile view.
Why?
In mobile view, tapping the Patterns menu in the site editor takes you to the "All Patterns" page, meaning that users cannot access the All template parts page unless they manually enter a URL.
How?
In between the two screens, add the Pattern Category List page.
In terms of implementation, it is similar to implementing the navigation route.
Testing Instructions
For each of the following pages, verify that screen navigation works as expected.
Design Menu
Patterns Menu
Patterns/Template Parts List
Pattern/Template Part Editor Canvas
Screenshots or screencast
The screenshot below shows the link relationships between each screen. Click on the image to see a high resolution version.