-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Navigation: Refactor display panel to use ToolsPanel #68011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation: Refactor display panel to use ToolsPanel #68011
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Thanks for the PR! This UI is quite different from other blocks' UI, so it definitely needs some custom styling 😅 It's mostly good, but here are some suggestions for improving the code quality. We can apply a class name directly to the { submenuAccessibilityNotice && (
<Notice
className="wp-block-navigation__submenu-accessibility-notice"
spokenMessage={ null }
status="warning"
isDismissible={ false }
>
{ submenuAccessibilityNotice }
</Notice>
) } The classname with { overlayMenuPreview && (
<VStack
id={ overlayMenuPreviewId }
spacing={ 4 }
style={ {
gridColumn: 'span 2',
} }
>
<OverlayMenuPreview
setAttributes={ setAttributes }
hasIcon={ hasIcon }
icon={ icon }
hidden={ ! overlayMenuPreview }
/>
</VStack>
) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
* Navigation: Refactor display panel to use ToolsPanel * Navigation: Add ToolsPanelItem in overlay-menu-preview * Navigation: Improve Layout and Styling for Overlay Menu and Submenus * Navigation: Refactor overlay menu preview controls Co-authored-by: SainathPoojary <sainathpoojary@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Part of: #67813
What?
Update Navigation Block to Implement ToolsPanel and ToolsPanelItem Components for Display Panel; Adjust Styles for Migration Compatibility.
Screenshots