Site Editor: Fix button hover style in sidebar navigation screen #66505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +6 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
ciampo
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Well spotted, and thank you for the fix
so the expected styles by the
.components-buttonselector are no longer applied.
Yet another instance of folks using internal classnames, which then breaks styles when the implementation details change.
I'm soon going to work on a public document including several DOs and DON'Ts — but let's also try to actively discourage folks from doing it every time we spot it in a PR (cc @WordPress/gutenberg-components @WordPress/gutenberg-design )
|
Thanks for the review! Note: Since this issue first appeared in WordPress 6.7, we need to backport this PR. |
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 69c9185 |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…dPress#66505) Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up #65361
What?
This PR fixes the styling of items in the site editor's navigation screen.
Why?
In #65361, buttons in the list view were replaced with
aelements instead ofButtoncomponents, so the expected styles by the.components-buttonselector are no longer applied.Testing Instructions
Screenshots or screencast
In the screenshot below, each item has the following states. Make sure the correct text color is applied to items in either state.