Skip to content

Table Block: Remove hasArrowIndicator prop #66204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

dhruvang21
Copy link
Contributor

@dhruvang21 dhruvang21 commented Oct 17, 2024

What?

The hasArrowIndicator prop in the ToolbarDropdownMenu component was removed over 4 years ago, and it no longer exists anywhere else, so it can be safely removed.

Why?

Closes:- #66203

How?

By removing the hasArrowIndicator prop from the ToolbarDropdownMenu component

@dhruvang21 dhruvang21 requested a review from ajitbohra as a code owner October 17, 2024 11:41
Copy link

github-actions bot commented Oct 17, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dhruvang21 <dhruvang21@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@torounit torounit added [Type] Code Quality Issues or PRs that relate to code quality [Block] Table Affects the Table Block labels Oct 17, 2024
@t-hamano t-hamano self-requested a review October 17, 2024 12:11
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix 👍

@t-hamano t-hamano changed the title Remove hasArrowIndicator prop Table Block: Remove hasArrowIndicator prop Oct 17, 2024
@t-hamano t-hamano added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Oct 17, 2024
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Oct 17, 2024
@t-hamano t-hamano merged commit b372527 into WordPress:trunk Oct 17, 2024
73 of 74 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.6 milestone Oct 17, 2024
karthick-murugan pushed a commit to karthick-murugan/gutenberg that referenced this pull request Nov 13, 2024
Co-authored-by: dhruvang21 <dhruvang21@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Table Affects the Table Block [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants