core(driver): add run warning on page load timeout #10538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
requested changes
Apr 2, 2020
|
|
||
| Homebrew should be able to install it correctly: `brew install protobuf@3.7.1` | ||
| Homebrew should be able to install it correctly: `brew install protobuf@3.7` |
There was a problem hiding this comment.
were these changes on purpose?
There was a problem hiding this comment.
yes drive by fix as I needed to run this on my new machine and brew install protobuf@3.7.1 doesn't work, it only supports @3.7
There was a problem hiding this comment.
yes drive by fix as I needed to run this on my new machine and
brew install protobuf@3.7.1doesn't work, it only supports @3.7
Looks like @3.7 is the official way to refer to the older version now
(our tests not working as desired on the lastest protobuf release it going to come around to bite us sooner or later...:)
patrickhulce
commented
Apr 2, 2020
Co-Authored-By: Connor Clark <cjamcl@google.com>
connorjclark
approved these changes
Apr 2, 2020
|
Still LGTM, i'll let you land it tho. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a toplevel warning when we reach the page load timeout. Apparently some of us thought we were already doing this anyway :)
Related Issues/PRs
#10527