Detect MariaDB vs MySQL #6072
Merged
Detect MariaDB vs MySQL #6072
+115
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrsdizzie @schlessera curious to hear your thoughts |
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Maybe it could be good to have one of the test runs use Mariadb instead of MySQL as well? |
|
Yes, see wp-cli/.github#123 Feel free to submit a PR :) |
Because we need these both in this project and in wp-cli-tests
mrsdizzie
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
MariaDB currently adds symlinks for
mysqlto usemariadbunder the hood, but that is being deprecated and people get warnings likeDeprecated program name. It will be removed in a future release, use 'mariadb' insteadWith this change, the idea is to offer better utils for commands like db-command to pick the right binary.
I suppose that could imply that we officially support MariaDB, but I guess since WordPress core itself recommends it, we should at least test it.