docker scheme: working-directory and stdin passing (reroll of #5974) #6057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleanly set the working directory before running a command => Use it instead and use `cd <...> ;` command-prefixing in vagrant/ssh cases 2. Using `docker` scheme, `wp post update 1 - <<<foo` didn't worked (issue wp-cli#4972) * Because STDOUT being a tty, `-t` is passed with no ability to inhibit this * Because docker `-i` flag is necessary => As such: * docker `-i` (`--interactive`) is introduced (with sensible autodetection) * `WP_CLI_DOCKER_NO_TTY` and `WP_CLI_DOCKER_NO_INTERACTIVE` environment variables are introduced to optionally inhibit these respective flags
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #6057 +/- ##
=======================================
Coverage ? 22.85%
Complexity ? 1747
=======================================
Files ? 87
Lines ? 6239
Branches ? 0
=======================================
Hits ? 1426
Misses ? 4813
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mrsdizzie
requested changes
Mar 1, 2025
mrsdizzie
approved these changes
Mar 3, 2025
This was referenced Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5974 reroll
docker execanddocker-compose execprovide an option to cleanly set the working directory before running a command=> Use it instead and use
cd <...> ;command-prefixing in vagrant/ssh casesUsing
dockerscheme,wp post update 1 - <<<foodidn't worked (issue passing stdin to command for docker-based WP instances #4972)-tis passed with no ability to inhibit this-iflag is necessary=> As such:
-i(--interactive) is introduced (with sensible autodetection)WP_CLI_DOCKER_NO_TTYandWP_CLI_DOCKER_NO_INTERACTIVEenvironment variables are introduced to optionally inhibit these respective flagsSpecial case to handle
behatruns (see #5974)