This repository was archived by the owner on Mar 3, 2023. It is now read-only.
add await to the async isValidGitDirectory #22578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since isValidGitDirectory is async, it actually returns Promise<boolean> which is always truthy That's probably not what the code meant
1 task
|
There might also be a bug on line 144 with non-awaited promises, but lgtm.com doesn't say anything about it, so maybe it's intentional?? |
|
Looks like line 144 is just returning the promise instead of returning the awaited value. It shouldn't make a difference but I feel like it should await the last call just to be consistent. |
See comment #22578 (comment) What I didn't realize was that line 144 was in an async return. So this commit shouldn't actually change any functionality. Nevertheless, await it for consistency.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing a Bug Fix
Identify the Bug
Fixes #22577
Description of the Change
Pretty self explanatory
isValidGitDirectory is an async function, and so actually returns a Promise which is always truthy
Alternate Designs
N/A
Possible Drawbacks
N/A
Verification Process
N/A (Hopefully)
Release Notes
The findGitDirectory function now checks if the directory is valid