Skip to content

Fix incorrect function prefixes in Dominant Color Images #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

felixarntz
Copy link
Member

Summary

This was flagged during plugin review of the "Dominant Color Images" submission. Of course this is intended to be a feature plugin, but we should still properly prefix functions. Specifically, using _ or wp_ as prefix is not allowed in plugins.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@felixarntz felixarntz added [Type] Enhancement A suggestion for improvement of an existing feature [Focus] Images [Plugin] Image Placeholders Issues for the Image Placeholders plugin (formerly Dominant Color Images) labels Jul 25, 2023
@felixarntz felixarntz added this to the PL Plugin 2.6.0 milestone Jul 25, 2023
@felixarntz felixarntz merged commit b09405b into trunk Jul 25, 2023
@felixarntz felixarntz deleted the fix/dominant-color-function-prefixes branch July 25, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Image Placeholders Issues for the Image Placeholders plugin (formerly Dominant Color Images) [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants