Skip to content

Sanitize target param before using it #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2023
Merged

Sanitize target param before using it #690

merged 1 commit into from
Mar 28, 2023

Conversation

felixarntz
Copy link
Member

Summary

Fixes #689

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@felixarntz felixarntz added [Type] Bug An existing feature is broken [Focus] Images [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) labels Mar 27, 2023
@felixarntz felixarntz added this to the 2.2.0 milestone Mar 27, 2023
@felixarntz felixarntz mentioned this pull request Mar 27, 2023
Closed
mukeshpanchal27
mukeshpanchal27 approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @felixarntz, LGTM!

@mukeshpanchal27 mukeshpanchal27 merged commit 998b1be into trunk Mar 28, 2023
@mukeshpanchal27 mukeshpanchal27 deleted the fix/unsanitized-request-target-param branch March 28, 2023 04:05
spacedmonkey
spacedmonkey reviewed Mar 28, 2023
View reviewed changes
Copy link
Member

@spacedmonkey spacedmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what is worth, I would have approved this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacedmonkey spacedmonkey spacedmonkey left review comments

@joemcgill joemcgill joemcgill approved these changes

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein

@mitogh mitogh Awaiting requested review from mitogh

Assignees
No one assigned
Labels
[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Bug An existing feature is broken
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

Add missing sanitization to image editing requests
4 participants
@felixarntz @spacedmonkey @joemcgill @mukeshpanchal27