Add install note after each PerfLab feature plugin in the plugin list table #1265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
swissspidy
reviewed
Jun 1, 2024
swissspidy
reviewed
Jun 1, 2024
Co-authored-by: Pascal Birchler <pascalb@google.com>
swissspidy
reviewed
Jun 2, 2024
Co-authored-by: Pascal Birchler <pascalb@google.com>
mukeshpanchal27
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Thanks for the PR. The code shows error so i have push 5019dd5 that fixed the issue.
ThierryA
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1222
As suggested by @justlevine in #1222 (comment):
Here's what that looks like in WP 6.5+:
The Performance Lab link goes to the Performance settings screen.
Note that I chose to say "This plugin is installed" as opposed to "This plugin was installed" because we don't keep track of whether or not a given feature plugin was indeed installed by the Performance Lab plugin. So it is intended to say that the Performance Lab in general installs a given feature plugin, but that's not to say it couldn't be installed directly.