Skip to content

Revisit how we handle object-cache.php conflicts #630

Closed
@jamesozzie

Description

@jamesozzie

Bug Description

Based on one users testing with the plugin when also using Redis Object Caching pro, Redis Cache pro is disabled when it determines an object-cache.php file present that isn't generated from Redis Object Caching pro. All the features of Redis Cache Pro are disabled when it comes across a non Redis Cache Pro object-cache file.

While it's possible any resolution on this may be applicable on the Redis Object Cache pro side, it may be an opportunity to check how the plugin handles such conflicts. At present we're moving the contents of a third party plugins object-cach.php file to object-cache-plst-orig.php, and then requesting that within the footer of the PL placed object-cache.php file. Maybe there's another way of using a third party caching plugin alongside the PL object-cache.php file.

Note also that we did make changes recently (PR #616) to resolve issues with third party plugin caching file contents being added to both the object-cache.php and object-cache-plst-orig.php files.

There is also an existing PL GitHub issue specific to Redis Cache Pro which, once actioned will provide a solution.

Steps to reproduce

  1. Install the PL plugin on a site that already have Redis Object Cache Pro active
  2. Check the object-cache.php file contents to ensure the PL plugin has overwritten the existing obect-cache file (while moving the existing one to object-cache-plst-orig.php
  3. Check your WP dashboard and notice the invalid status of the drop-in file

Screenshots

image

Metadata

Metadata

Assignees

Labels

InfrastructureIssues for the overall performance plugin infrastructure[Plugin] Performance LabIssue relates to work in the Performance Lab Plugin only[Type] BugAn existing feature is broken

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions