Skip to content

Improve image handling approach in Modern Image Formats #1259

Closed
@adamsilverstein

Description

@adamsilverstein

Feature Description

Switch from using the_content filter to using wp_calculate_image_srcset when replacing images.

As @joemcgill points out in #1236 (review) we should probably switch the image processing approach. Currently the webp_uploads_update_image_references function is attached to the_content filter and processes all images on the page using a regex. Instead, we can leverage the filters core runs on images after it does a similar regex against the content. Namely, the wp_calculate_image_srcset or wp_content_img_tag filters are potential places to add our logic.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Needs DevAnything that requires development (e.g. a pull request)[Plugin] Modern Image FormatsIssues for the Modern Image Formats plugin (formerly WebP Uploads)[Type] EnhancementA suggestion for improvement of an existing featureno milestonePRs that do not have a defined milestone for release

    Type

    No type

    Projects

    Status

    Done 😃

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions