Data: graduate the __experimentalResolveSelect function to a stable status #28544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +90 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
@noisysocks, is it something that deserves a dev note for WP 5.7? |
|
It will need a dev note yes but maybe for 5.8 depending on if it makes the cut-off. |
noisysocks
approved these changes
Feb 4, 2021
|
Thanks @jsnajdr. Could you please add a note to the |
|
It should be fine to merge it now with the docs that @noisysocks mentioned. |
cbb59d5 to
f65bfc4
Compare
|
Changelog entry added, going to merge now 👍 |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
registry.resolveSelect()function and theresolveSelectcontrol are already widely used and they proved useful. They no longer need to be kept in the experimental status.This PR removes the
__experimentalprefix from all definitions and usages.Also addresses a little performance issue pointed out by @noisysocks in ffef5a7#r565022458: instead of mapping the selectors again and again on every call to
getResolveSelectors(), we now map them all on store creation/registration.