Link autocompleter: decode post title HTML entities #65589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n `fetchLinkSuggestions` where the `rendered` title (containing HTML entities) is also being decoded.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +19 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Sep 24, 2024
|
Waaah! All the E2E fails are passing locally for me. Looking at the commit history, I think it's affecting a lot of branches so my guess is that this PR okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves #65578
For link autocompleters, make
titleproperty consistent with that infetchLinkSuggestionswhere therenderedtitle (containing HTML entities) is also being decodedWhy?
So that the post titles are rendered correctly.
How?
Running post titles through
decodeEntities, which is consistent with navigation links and fetchLinkSuggestions.Testing Instructions
Bob's "post" !@#$%^&*[[to trigger link autocompleteTesting Instructions for Keyboard
Screenshots or screencast