Skip to content

REST API: Add the site reading options to the index #8345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented Feb 18, 2025

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@TimothyBJacobs
Copy link
Member

This looks good to me. Could be cool to add links to the relevant REST API routes for those page ids.

@Mamaduka
Copy link
Member Author

Could be cool to add links to the relevant REST API routes for those page ids.

@TimothyBJacobs, is this something we want to include now or as a follow-up?

@TimothyBJacobs
Copy link
Member

I don't think it should block merge. But yeah could be a cool include or follow up.

@Mamaduka Mamaduka force-pushed the add/reading-settings-rest-api-index branch from d0bdff3 to 2178801 Compare February 26, 2025 14:38
@Mamaduka
Copy link
Member Author

Create the Trac ticket and update unit test files.

I don't think it should block merge. But yeah could be a cool include or follow up.

Let's follow-up on this.

Copy link
Contributor

@audrasjb audrasjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good to me.

@Mamaduka Mamaduka marked this pull request as ready for review February 26, 2025 14:52
Copy link

github-actions bot commented Feb 26, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props mamaduka, audrasjb, spacedmonkey, timothyblynjacobs.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@spacedmonkey spacedmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mamaduka Mamaduka added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Feb 27, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Feb 27, 2025
@Mamaduka
Copy link
Member Author

@Mamaduka Mamaduka closed this Feb 27, 2025
@Mamaduka Mamaduka deleted the add/reading-settings-rest-api-index branch February 27, 2025 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants