Skip to content

report: add analytics hook for insights state #16466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 26, 2025
Merged

report: add analytics hook for insights state #16466

merged 6 commits into from
Apr 26, 2025

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Apr 25, 2025 •
edited
Loading

  • add DEFAULT state to insight toggle
  • add analytics hook for initial insight state; and for toggling it
  • update analytics hook / viewer to use gtag (GA4) instead of ga

this probably works. have to wait 24hr to know

@connorjclark connorjclark requested a review from a team as a code owner April 25, 2025 23:29
@connorjclark connorjclark requested review from paulirish and removed request for a team April 25, 2025 23:29
paulirish
paulirish reviewed Apr 26, 2025
View reviewed changes
@connorjclark connorjclark merged commit aa401d3 into main Apr 26, 2025
29 of 30 checks passed
@connorjclark connorjclark deleted the gtag-insight branch April 26, 2025 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connorjclark @paulirish