core(asset-saver): fix handling of undefined trace #15451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
commented
Sep 12, 2023
| fs.mkdirSync(tmpDir, {recursive: true}); | ||
| const artifacts = { | ||
| DevtoolsLog: [{message: 'first'}, {message: 'second'}], | ||
| Trace: {traceEvents}, | ||
| }; | ||
|
|
||
| return assetSaver.saveAssets(artifacts, dbwResults.audits, `${tmpDir}/the_file`); | ||
| await assetSaver.saveAssets(artifacts, dbwResults.audits, `${tmpDir}/the_file`); |
There was a problem hiding this comment.
Ope, previous attempt had multiple calls to saveAssets, I'll change it back if someone wants
adamraine
commented
Sep 12, 2023
| const saveAll = allAssets.map(async (assets, index) => { | ||
| if (assets.devtoolsLog) { | ||
| const devtoolsLogFilename = `${pathWithBasename}-${index}${devtoolsLogSuffix}`; | ||
| await saveDevtoolsLog(assets.devtoolsLog, devtoolsLogFilename); |
There was a problem hiding this comment.
Quick callout, using saveDevtoolsLog instead of a generic JSON.stringify and fs.writeFileSync
There was a problem hiding this comment.
this is a readability change, but in what direction is subjective. seems fine.
connorjclark
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15450