core(report-generator): add url to CSV output #10656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const table = Object.values(lhr.categories).map(category => { | ||
| return category.auditRefs.map(auditRef => { | ||
| const audit = lhr.audits[auditRef.id]; | ||
| // CSV validator wants all scores to be numeric, use -1 for now | ||
| const numericScore = audit.score === null ? -1 : audit.score; | ||
| return [category.title, audit.id, audit.title, audit.scoreDisplayMode, numericScore] | ||
| return [lhr.requestedUrl, lhr.finalUrl, category.title, audit.id, audit.title, | ||
| audit.scoreDisplayMode, numericScore] |
There was a problem hiding this comment.
we gotta remove the push action. it doubles up on the lint errors
connorjclark
approved these changes
Apr 28, 2020
brendankenny
approved these changes
Apr 28, 2020
| const table = Object.values(lhr.categories).map(category => { | ||
| return category.auditRefs.map(auditRef => { | ||
| const audit = lhr.audits[auditRef.id]; | ||
| // CSV validator wants all scores to be numeric, use -1 for now | ||
| const numericScore = audit.score === null ? -1 : audit.score; | ||
| return [category.title, audit.id, audit.title, audit.scoreDisplayMode, numericScore] | ||
| return [lhr.requestedUrl, lhr.finalUrl, category.title, audit.id, audit.title, |
There was a problem hiding this comment.
wait, so is there going to be two urls per line in the CSV?
There was a problem hiding this comment.
wait, so is there going to be two urls per line in the CSV?
I can live with that and don't care, just to be clear :)
There was a problem hiding this comment.
correct there will be :)
| const table = Object.values(lhr.categories).map(category => { | ||
| return category.auditRefs.map(auditRef => { | ||
| const audit = lhr.audits[auditRef.id]; | ||
| // CSV validator wants all scores to be numeric, use -1 for now | ||
| const numericScore = audit.score === null ? -1 : audit.score; | ||
| return [category.title, audit.id, audit.title, audit.scoreDisplayMode, numericScore] | ||
| return [lhr.requestedUrl, lhr.finalUrl, category.title, audit.id, audit.title, | ||
| audit.scoreDisplayMode, numericScore] |
There was a problem hiding this comment.
i respectfully disagree
yeah, I think that's an eslintrc bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pushing back against CSV as a thing is more work than making it better :)
Related Issues/PRs
closes #10654